fix: do not fetch a random inventory account when multiple inventory accounts exist (backport #57626) - #57631
Merged
rohitwaghchaure merged 4 commits intoJul 31, 2026
Conversation
Contributor
Author
|
Cherry-pick of 386a4ac has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Removed redundant test for valuation taxes in purchase receipt.
For asset purchase receipts or provisional accounting with perpetual inventory disabled, GL entries do not use warehouse accounts. Building the full warehouse account map in that case now throws when a company has multiple inventory accounts and no default, breaking asset receipt submission. Mirrors the gating on develop. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The conflict resolution kept the pre-backport copy of test_valuation_taxes_lcv_repost_after_billing, which enables perpetual inventory on _Test Company without configuring a default inventory account. The test then failed on submit and leaked the perpetual inventory flag, breaking every stock test that ran after it in the same process. Restore the cherry-picked version from #57626. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
rohitwaghchaure
enabled auto-merge (squash)
July 31, 2026 05:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #57626 done by [Mergify](https://mergify.com).